Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Scala Native 0.5.x changes in publishing artifacts #2460

Merged

Conversation

WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented Oct 12, 2023

Upcoming Scala Native 0.5.x changes how some artifacts are published:

  1. Scala Standard Library (scalalib) is now published for each Scala version, instead of being published once for Scala binary version. It is required to properly handle possible changes in sources between versions (mostly in Scala3) and to prepare for SIP-51 and potential unfreezing of Scala 2.13 stdlib.
  2. scalalib does no longer contain transitive dependency on Java Standard Library (javalib) re-implementation. This dependency is now handled explicitly.

@WojciechMazur
Copy link
Contributor Author

Change was tested locally based on published 0.5.0-SNAPSHOT versions. I don't think it's good idea to add dependency on snapshots in tests

@Gedochao
Copy link
Contributor

@WojciechMazur I wonder if we can't wait for a stable 0.5.0 release, so that we can test for it?

@WojciechMazur
Copy link
Contributor Author

I wonder if we can't wait for a stable 0.5.0 release, so that we can test for it?

We can wait, but there are some early adopters using 0.5.0-SNAPSHOTS who'd like to use it. I'll this decision to the ScalaCLI team

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's make sure we test for this when we bump Scala Native to 0.5.0

@Gedochao Gedochao merged commit 44cc8cd into VirtusLab:main Oct 13, 2023
38 checks passed
@WojciechMazur WojciechMazur deleted the scala-native/prepare-for-0.5.x branch October 13, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants