Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude conflicting dependencies #2541

Merged
merged 2 commits into from Nov 16, 2023
Merged

Exclude conflicting dependencies #2541

merged 2 commits into from Nov 16, 2023

Conversation

MaciejG604
Copy link
Contributor

Fixes #2421

@MaciejG604 MaciejG604 marked this pull request as draft November 14, 2023 13:33
@MaciejG604 MaciejG604 marked this pull request as ready for review November 14, 2023 15:03
@MaciejG604 MaciejG604 mentioned this pull request Nov 14, 2023
Closed
@MaciejG604
Copy link
Contributor Author

I've also deleted the // Depending on version compiled with Scala 3 pulls older stdlib comment since it's no longer relevant.

@MaciejG604
Copy link
Contributor Author

MaciejG604 commented Nov 15, 2023 •
edited

To check the correctness of this fix run:

./mill cli.ivyDepsTree --whatDependsOn com.lihaoyi:geny_2.13 \
--whatDependsOn  org.scala-lang.modules:scala-collection-compat_2.13 \
--whatDependsOn  com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core_2.13 \
--whatDependsOn  com.lihaoyi:sourcecode_2.13 \
--whatDependsOn  ai.kien:python-native-libs_2.13 \
--whatDependsOn  com.lihaoyi:os-lib_2.13

The output should be empty

@MaciejG604 MaciejG604 merged commit 9b7a75d into VirtusLab:main Nov 16, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scala-cli depends on multiple versions of artifacts with conflicting cross-version suffixes
3 participants
@MaciejG604 @tgodzik @Gedochao