Separate Scala REPL classpath from user dependencies #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
maintenance/fix-repl-cp
branch
from
d403c01
to
25d067d
Compare
MaciejG604
reviewed
Dec 5, 2023
tgodzik
reviewed
Dec 5, 2023
Gedochao
force-pushed
the
maintenance/fix-repl-cp
branch
from
25d067d
to
531e3f5
Compare
Gedochao
force-pushed
the
maintenance/fix-repl-cp
branch
from
531e3f5
to
2d16e27
Compare
Gedochao
force-pushed
the
maintenance/fix-repl-cp
branch
from
2d16e27
to
78aca99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2582
This separates the Scala REPL classpath from user dependencies classpath, preventing clashes and unintended bumps of compiler dependencies.
This also allows to use the recent
jnaversion on the Scala REPL withaarch64Java releases, for more details read #2582 (comment)NOTE: this only separates the Scala REPL, and not the Ammonite REPL.
Ammonite REPL does not support a
--classpathargument.It would likely be possible to either exclude transitive compiler dependencies in the user dependencies when launching the Ammonite REPL, or preload deps with a script to prevent clashes there, too.
However, as the Ammonite REPL does not have much in terms of dependencies in the first place, this is perhaps not much of an issue, really.
Isolating the Ammonite REPL classpath is out of the scope of this PR, either way.