Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a subcategories layer for guides & cookbooks #2612

Merged
merged 4 commits into from Dec 7, 2023

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Dec 5, 2023

Relevant ticket: #2592

image

Guides & cookbooks are now divided into subcategories in the sidebar.
The division is done according to the existing index docs.
Some recent docs haven't been present in the indexes, so I added them.

I also cleaned up some other stuff, like consistently using relative links where able (so that IDEs can do the busywork for us when we move docs around) and other minor things.

Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added some comments about possible further improvements. If you think they are worth considering, we can add them to the issue.

@@ -3,7 +3,7 @@ title: IntelliJ IDEA setup
sidebar_position: 11
---

import {ChainedSnippets} from "../../src/components/MarkdownComponents.js";
import {ChainedSnippets} from "../../../src/components/MarkdownComponents.js";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to join the Intellij cookbooks into one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could, but that would make it complex enough to make it a guide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, besom's contributing doc seems to be linking to one of them, if we end up merging these into a guide, then we should update it in there: https://github.com/VirtusLab/besom/blob/develop/CONTRIBUTING.md#intellij-setup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we join instant startup with scripts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to the IntelliJ ones, it'd make the result a guide rather than a cookbook

@@ -15,38 +15,41 @@ the [cookbooks section](../cookbooks/intro.md).

These few guides are a good starting point when learning how to use Scala CLI.

- [Configuration](./configuration.md) - learn how to configure various options, and what configuration styles are best
- [Configuration](introduction/configuration.md) - learn how to configure various options, and what configuration styles are best
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to figure out now, what is the difference between a guide and cook book. Isn't it basically the same?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, the difference is quite slim, maybe we should consider merging them?
Although some of them won't really fit the guides, those could be left in a separate Examples section.
WDYT?
Of course it's for a potential separate ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the idea is for cookbooks to be simple step-by-step posts with clear examples, while guides are meant to be more in-depth.
Perhaps Examples would be a more readable category, rather than cookbooks...
But then, we might need a lot more of them, cause such a change would make more people to look for examples in there, rather than in command docs or guides.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, we could indeed merge them and only have guides... dunno, might be worth discussing it

@Gedochao Gedochao merged commit 86f1169 into VirtusLab:stable Dec 7, 2023
58 checks passed
@Gedochao Gedochao deleted the docs/clean-up-categories branch December 7, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants