Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove semantics Compliant for asInstaceOf #2614

Merged
merged 1 commit into from Dec 11, 2023

Conversation

MaciejG604
Copy link
Contributor

@MaciejG604 MaciejG604 commented Dec 6, 2023

Fixes #2602
Connected to VirtusLab/scala-js-cli#40

Also added aliases for optimisation mode for Scala JS, to have the same as in the sbt plugin fastLinkJs and fullLinkJs to avoid questions such as in #2184 .

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaciejG604 MaciejG604 merged commit e96c20f into VirtusLab:main Dec 11, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The default semantic of asInstanceOfs on Scala.js should not be Compliant
2 participants