Fix special handling for the -Xplugin-list compiler option
#2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
maintenance/compiler-plugin-support
branch
from
7d6466b
to
94b5fb6
Compare
…test for compiler plugins
Gedochao
force-pushed
the
maintenance/compiler-plugin-support
branch
from
94b5fb6
to
e1d2253
Compare
MaciejG604
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant ticket: #2621
The
-Xplugin-listcompiler option wasn't being handled correctly and erroneously required an input to be passed at all times.I also added an integration test for building a custom compiler plugin with Scala CLI & verifying it is applied to the compiler.
This currently requires the
--server=falseflag, as it doesn't work correctly with Bloop 😕