Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the toolkit latest deprecation warning from being logged more than once #2657

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Jan 9, 2024

Adding the toolkit dependency with the deprecated latest version causes the warning to be logged no less than 6 times (sic!)

scala-cli --toolkit latest -e 'println(os.pwd)'
# Using 'latest' for toolkit is deprecated, use 'default' to get more stable behaviour:
#  --toolkit default
# Using 'latest' for toolkit is deprecated, use 'default' to get more stable behaviour:
#  --toolkit default
# Using 'latest' for toolkit is deprecated, use 'default' to get more stable behaviour:
#  --toolkit default
# Using 'latest' for toolkit is deprecated, use 'default' to get more stable behaviour:
#  --toolkit default
# Using 'latest' for toolkit is deprecated, use 'default' to get more stable behaviour:
#  --toolkit default
# Using 'latest' for toolkit is deprecated, use 'default' to get more stable behaviour:
#  --toolkit default
# Compiling project (Scala 3.3.1, JVM (17))
# Compiled project (Scala 3.3.1, JVM (17))
# ~/IdeaProjects/scala-cli-tests

This scales it down to a reasonable and desired once.

scala-cli --toolkit latest -e 'println(os.pwd)'
# Using 'latest' for toolkit is deprecated, use 'default' to get more stable behaviour:
#  --toolkit default
# Compiling project (Scala 3.3.1, JVM (17))
# Compiled project (Scala 3.3.1, JVM (17))
# ~/IdeaProjects/scala-cli-tests

@Gedochao Gedochao force-pushed the maintenance/fix-toolkit-warnings branch from 9f28339 to d7fe439 Compare January 9, 2024 10:55
@Gedochao Gedochao enabled auto-merge (squash) January 9, 2024 10:57
@Gedochao Gedochao merged commit 64bb1e2 into VirtusLab:main Jan 9, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants