Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove user.home hack #2710

Merged
merged 3 commits into from Feb 7, 2024
Merged

remove user.home hack #2710

merged 3 commits into from Feb 7, 2024

Conversation

kasiaMarek
Copy link
Collaborator

@kasiaMarek kasiaMarek commented Feb 2, 2024 •
edited

resolves: #2585

Upstream fix made os.pwd not fail when os.home is invalid. But I wonder if os.home shouldn't always be wrapped in a try clause, if it can be invalid.

@Gedochao
Copy link
Contributor

Gedochao commented Feb 2, 2024

https://github.com/VirtusLab/scala-cli/blob/main/modules/integration/src/test/scala/scala/cli/integration/RunTestDefinitions.scala#L2142-L2167
We should also adjust the relevant integration test to be sure it's not needed anymore, even without the env override.

Gedochao
Gedochao approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit dc8edf3 into VirtusLab:main Feb 7, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove user.home hack when fix gets released in os-lib
2 participants
@kasiaMarek @Gedochao