Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about --preamble in assembly packaging documentation #2713

Merged
merged 2 commits into from Feb 7, 2024

Conversation

spacebanana420
Copy link
Contributor

This is a short modification to scala-cli's website documentation. The changed file in question is website/docs/commands/package.md.

The changed area is the part about assembly packaging. I added information on how you can use --preamble=false to generate an assembly JAR that is not self-executable and therefore can be run with Java directly. This information is followed by a very similar example to the already existing one.

@Gedochao Gedochao self-requested a review February 7, 2024 08:26
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the contribution! LGTM, I just commented on a minor nitpick.

website/docs/commands/package.md Outdated Show resolved Hide resolved
@Gedochao Gedochao merged commit 9e30ea7 into VirtusLab:stable Feb 7, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants