Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for creation of custom toolkit #2715

Merged

Conversation

yadavan88
Copy link
Contributor

Based on this discussion and this issue, I added the information on how to create a custom toolkit. In the documentation, I referred to the sample toolkit created here.

Please let me know if this looks fine or if any changes are required.

Thanks
Yadu

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!
I just commented on some nitpicks.

website/docs/guides/advanced/custom-toolkit.md Outdated Show resolved Hide resolved
website/docs/guides/advanced/custom-toolkit.md Outdated Show resolved Hide resolved
website/docs/guides/advanced/custom-toolkit.md Outdated Show resolved Hide resolved
@yadavan88
Copy link
Contributor Author

Thanks @Gedochao I applied your changes.

@Gedochao Gedochao force-pushed the 2639-custom-toolkit-documentation branch from 52b7e7e to 559105b Compare February 7, 2024 14:53
yadavan88 and others added 4 commits February 7, 2024 15:58
Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com>
Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com>
Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com>
@Gedochao Gedochao force-pushed the 2639-custom-toolkit-documentation branch from 559105b to 53163c6 Compare February 7, 2024 14:58
@Gedochao
Copy link
Contributor

Gedochao commented Feb 7, 2024

As the CI didn't trigger as it should for some reason, I rebased the PR from the latest stable branch, will merge it once the CI is green

@Gedochao Gedochao linked an issue Feb 7, 2024 that may be closed by this pull request
@Gedochao Gedochao merged commit c596951 into VirtusLab:stable Feb 8, 2024
58 checks passed
@yadavan88 yadavan88 deleted the 2639-custom-toolkit-documentation branch February 8, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to create custom toolkits
2 participants