fix: stick to a tcp connection for Bloop on non standard OS's. #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll be honest, I haven't really dug into the JNI/JNA issues, so I'm unsure if there is a better more appropriate to get domain sockets to work on FreeBSD in this scenario, but when testing it with --bloop-bsp-protocol being set to tcp it worked. So this is just a quick fix to ensure that the default for FreeBSD for now is tcp. Closes VirtusLab#271
alexarchambault
approved these changes
Oct 24, 2021
Ah yea, that's better 👍🏼 |
ckipp01
changed the title
romanowski
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be honest, I haven't really dug into the JNI/JNA issues, so I'm
unsure if there is a better more appropriate to get domain sockets to
work on FreeBSD in this scenario, but when testing it with --bloop-bsp-protocol
being set to tcp it worked. So this is just a quick fix to ensure that the
default for FreeBSD for now is tcp.
Closes #271