Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Scala LTS as the default version while cross compiling all Scala 3 modules on both LTS & Next #2752

Merged
merged 16 commits into from Feb 26, 2024
Merged

Use Scala LTS as the default version while cross compiling all Scala 3 modules on both LTS & Next #2752

merged 16 commits into from Feb 26, 2024

Conversation

Gedochao
Copy link
Contributor

What this PR does:

  • all Scala3-compatible modules will now be cross compiled on both LTS (atm 3.3.2) & Next (atm 3.4.0)
  • the internal Scala version will default to LTS (atm 3.3.2)
    • all launchers used for publishing & integration tests will use the default internal version (which is the 3.3.2 LTS)
    • we won't run integration tests twice, we'll just do it once for LTS

@Gedochao Gedochao force-pushed the maintenance/lts-cross-next branch 3 times, most recently from 0fab65e to ffa7c29 Compare February 23, 2024 13:22
@Gedochao
NIT rename LTS prefix version in constants
743959a
@Gedochao
Build Scala CLI with Scala LTS, but default the Scala version for use…
a8e4601 
…rs to Next
@Gedochao
Always refer to Scala 3 LTS & Next versions explicitly, rather than a…
ea3cdc5 
… (ambigous) `scala3` constant
@Gedochao
Favor default internal Scala version rather than explicit calls to Sc…
b3af065 
…ala 3 LTS in module dependencies calls
@Gedochao
NIT remove dead code
1cb9871
@Gedochao
Cross compile build-macros on Scala 3 LTS & Next
8263d0c
@Gedochao
Cross compile core on Scala 3 LTS & Next
5d03306
@Gedochao
Cross compile options on Scala 3 LTS & Next
34018de
@Gedochao
Cross compile directives on Scala 3 LTS & Next
a3213a2
@Gedochao
Cross compile build-module on Scala 3 LTS & Next
e7780f5
@Gedochao
Cross compile scala3-runtime on Scala 3 LTS & Next
98c8e2a
@Gedochao
Cross compile cli on Scala 3 LTS & Next
ce36200
@Gedochao
Cross compile scala3-graal-processor on Scala 3 LTS & Next
05eaedd
@Gedochao
Cross compile docs-tests on Scala 3 LTS & Next
1d0b07c
@Gedochao
Cross compile generate-reference-doc on Scala 3 LTS & Next
fc744c4
@Gedochao
Always default to the internal Scala 3 version for Scala 3 cross-comp…
548a51b 
…iled modules
@Gedochao Gedochao marked this pull request as ready for review February 23, 2024 14:39
@Gedochao Gedochao merged commit f3369c2 into VirtusLab:main Feb 26, 2024
58 checks passed
@Gedochao Gedochao deleted the maintenance/lts-cross-next branch February 26, 2024 07:36
@Gedochao Gedochao mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@kasiaMarek kasiaMarek Awaiting requested review from kasiaMarek

@jkciesluk jkciesluk Awaiting requested review from jkciesluk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gedochao @tgodzik