Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publishing of artifacts to include non-cross-compiled modules #2759

Merged

Conversation

Gedochao
Copy link
Contributor

Non-cross-compiled modules aren't included in the __[] wildcard, which caused scala-cli-bsp to be skipped when publishing to sonatype.
That in turn broke our nightlies

scala-cli --cli-version nightly -version
# Fetching Scala CLI 1.1.3-38-gac4a7b4a9-SNAPSHOT
# Error downloading org.virtuslab.scala-cli:scala-cli-bsp:1.1.3-38-gac4a7b4a9-SNAPSHOT
#   not found: /Users/pchabelski/.ivy2/local/org.virtuslab.scala-cli/scala-cli-bsp/1.1.3-38-gac4a7b4a9-SNAPSHOT/ivys/ivy.xml
#   not found: https://repo1.maven.org/maven2/org/virtuslab/scala-cli/scala-cli-bsp/1.1.3-38-gac4a7b4a9-SNAPSHOT/scala-cli-bsp-1.1.3-38-gac4a7b4a9-SNAPSHOT.pom
#   not found: https://oss.sonatype.org/content/repositories/snapshots/org/virtuslab/scala-cli/scala-cli-bsp/1.1.3-38-gac4a7b4a9-SNAPSHOT/scala-cli-bsp-1.1.3-38-gac4a7b4a9-SNAPSHOT.pom
#   No fallback URL found

(and would have broken the Scala CLI slim jar on a subsequent release, although that'd have been tough to spot)

.github/workflows/ci.yml Show resolved Hide resolved
@Gedochao Gedochao enabled auto-merge (squash) February 27, 2024 12:00
@Gedochao Gedochao merged commit 6e92366 into VirtusLab:main Feb 27, 2024
36 checks passed
@Gedochao Gedochao deleted the maintenance/fix-publishing-artifacts branch February 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants