New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add launcher options allowing to override the default Scala version #2860
Add launcher options allowing to override the default Scala version #2860
Conversation
227da37
to
0664cf0
Compare
cc @bishabosha |
nice, Is it necessary to add another test to assert it fails if --cli-default-scala-version is provided twice? |
modules/options/src/main/scala/scala/build/options/BuildOptions.scala
Outdated
Show resolved
Hide resolved
0664cf0
to
4f08f0e
Compare
@bishabosha that's guaranteed by |
f8af5c1
to
861b894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but there are two places, where this doesn't seem to be propagated and I don't know if that is on purpose:
- scala version used for
export
, - when scala version is downgraded for ammonite it's check against
defaultScalaVersion
not the override default
@kasiaMarek nice catch, let me fix those |
861b894
to
d5427b0
Compare
Changes:
|
1f07e78
to
d5a0190
Compare
nice |
Relevant to #2838
This PR adds 2 new launcher options:
--cli-default-scala-version
&--cli-predefined-repository
--cli-default-scala-version
allows to override the default Scala version (which can then be overridden with-S
):--cli-predefined-repository
is an equivalent to the existing--repo
option for building sub-commands, but can be passed as a launcher option. This i.e. allows to pass a local repository containing compiler artifacts.