Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve launcher options handling #2931

Merged
merged 3 commits into from
May 24, 2024
Merged

Improve launcher options handling #2931

merged 3 commits into from
May 24, 2024

Conversation

Gedochao
Copy link
Contributor

Fixes #1263

@Gedochao Gedochao force-pushed the maintenance/make-bsp-respect-launcher-args branch 2 times, most recently from cbdcf5a to 88e6bb2 Compare May 23, 2024 18:50
@Gedochao Gedochao force-pushed the maintenance/make-bsp-respect-launcher-args branch from 88e6bb2 to 4097761 Compare May 23, 2024 19:55
@Gedochao Gedochao changed the title Ensure launcher options of setup-ide are respected by bsp Improve launcher options handling May 23, 2024
@Gedochao Gedochao mentioned this pull request May 23, 2024
Merged
@Gedochao
Copy link
Contributor Author

Kudos for @bishabosha for setting up the repo with Scala 3.5.0-RC1-fakeversion-bin-SNAPSHOT jars:

@Gedochao Gedochao marked this pull request as ready for review May 23, 2024 21:08
@Gedochao
Copy link
Contributor Author

Fixes #1683

@Gedochao Gedochao linked an issue May 23, 2024 that may be closed by this pull request
BSP doesn't work with nightly/snapshot versions of the CLI #1683
Closed
@Gedochao Gedochao force-pushed the maintenance/make-bsp-respect-launcher-args branch from a71748c to 6fefa30 Compare May 23, 2024 22:56
tgodzik
tgodzik approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/cli/src/main/scala/scala/cli/commands/bsp/Bsp.scala Show resolved Hide resolved
@Gedochao Gedochao merged commit c04ef18 into VirtusLab:main May 24, 2024
75 checks passed
@Gedochao Gedochao deleted the maintenance/make-bsp-respect-launcher-args branch May 24, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha left review comments

@tgodzik tgodzik tgodzik approved these changes

@kasiaMarek kasiaMarek Awaiting requested review from kasiaMarek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Gedochao @tgodzik @bishabosha