clean .bsp/scala-cli.json when you run clean #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it might be best to do this when you run clean. I hit on this a couple times now where something was out of sync or not working which caused me to attempt to do a `scala-cli clean`. However, when you clean it removes the `.scala/` dir, but not the entry that was created in `.bsp/scala-cli.json` which still references the `.scala/ide-options.json` file which no longer exists after the clean. Then since the BSP entry still exists, BSP discovery still triggers in Metals, and then it sends in the initialize request, but scala-cli just freezes and doesn't respond. This fix just ensures that when you run `scala-cli` clean, it cleans up both the `.scala/` and also the `.bsp/scala-json`.
alexarchambault
force-pushed
the
clean-bsp
branch
from
74beb04
to
f7fece3
Compare
alexarchambault
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it might be best to do this when you run clean. I hit on this a
couple times now where something was out of sync or not working which
caused me to attempt to do a
scala-cliclean. However, when you cleanit removes the
.scaladir, but not the entry that was created in.bsp/scala-cli.jsonwhich still references the.scala/ide-options.jsonfile which no longer exists after the clean.Then since the BSP entry still exists, BSP discovery still triggers in
Metals, and then it sends in the initialize request, but scala-cli just
freezes and doesn't respond. This fix just ensures that when you run
scala-cliclean, it cleans up both the.scala/and also the.bsp/scala-json.