Use Bloop fork, default to 100% domain sockets for Bloop communication #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
bleep
branch
from
79474e2
to
9707468
Compare
|
|
|
How come this is necessary? We have control over bloop. We can upstream the necessary changes there, if required. |
|
https://github.com/oyvindberg/bleep , but I don't think anyone's using blaap or bluup |
|
FYI, the fork of Bloop (called bleep for now) lives here. The name collision with https://github.com/oyvindberg/bleep is unfortunate, but scala-cli/bleep might be temporary. Some of the motivations to work from it rather than from upstream Bloop are
It's 100% my own personal initiative for now. We (VirtusLab) might soon come up with plans to ease the maintenance of Bloop, and hopefully make this fork unnecessary. |
alexarchambault
force-pushed
the
bleep
branch
from
9707468
to
4ae93ca
Compare
alexarchambault
force-pushed
the
bleep
branch
2 times, most recently
from
488264c
to
4a2d12a
Compare
alexarchambault
force-pushed
the
bleep
branch
3 times, most recently
from
f4a1e87
to
4b61568
Compare
Merged
alexarchambault
force-pushed
the
bleep
branch
7 times, most recently
from
afcdccb
to
208536f
Compare
So that we can go 100% domain sockets.
So that we can still download the launchers via the GitHub actions UI if ever docker image building fails.
alexarchambault
force-pushed
the
bleep
branch
from
5ad9470
to
bd768a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.