Start Bloop with Java 17 #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
bloop-java-17
branch
4 times, most recently
from
e2d8c1d
to
f3be2a1
Compare
So that we get actual stack traces there.
alexarchambault
force-pushed
the
bloop-java-17
branch
from
f3be2a1
to
ec98d69
Compare
Required by JDK >= 11 (maybe even >= 9).
alexarchambault
force-pushed
the
bloop-java-17
branch
from
ec98d69
to
410885a
Compare
tpasternak
reviewed
Dec 22, 2021
| FROM gcr.io/distroless/base-debian10 | ||
| ADD scala-cli /usr/local/bin/scala-cli | ||
| COPY --from=build-env /lib/x86_64-linux-gnu/libz.so.1 /lib/x86_64-linux-gnu/libz.so.1 |
There was a problem hiding this comment.
I'm not sure, but we probably should copy distroless license as well
There was a problem hiding this comment.
This file originates from the debian:stable-slim image, not a distroless one. I guess this should be fine…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.