Use Java 17 domain socket support exclusively #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more ipcsocket JNI stuff
alexarchambault
force-pushed
the
bloop-java-17
branch
from
2f3a216
to
755f378
Compare
For the Windows CI job, that uses a Java 16 GraalVM distribution.
alexarchambault
force-pushed
the
bloop-java-17
branch
from
755f378
to
0abbbd4
Compare
alexarchambault
force-pushed
the
bloop-java-17
branch
from
0abbbd4
to
eae634f
Compare
Often running into weird issues with Bloop and domain sockets, when temp dirs are involved…
alexarchambault
force-pushed
the
bloop-java-17
branch
13 times, most recently
from
4019728
to
c48b705
Compare
/bin/sh has issues with '+' or '%' in PATH (don't remember which). cs puts entries with such characters when using temurin:17. So from /bin/sh, the temurin:17 entry in PATH is ignored, which is an issue. To work around that, we ensure that bash is used instead of sh wherever possible.
- avoid the use of Try around os.proc (better directly check the exit code or if the file we run exists) - ensure we don't ask a question when --force is passed
alexarchambault
force-pushed
the
bloop-java-17
branch
2 times, most recently
from
dd67dfb
to
717987f
Compare
alexarchambault
force-pushed
the
bloop-java-17
branch
2 times, most recently
from
5f20a9c
to
73ada0d
Compare
Running a bit short on memory on Windows workers…
Saw some OOM exceptions lately on the CI…
alexarchambault
force-pushed
the
bloop-java-17
branch
from
73ada0d
to
d32ab0a
Compare
Image resizing is only used by MSI packaging, and was already disabled in the Scala CLI native Windows executable. Disabling it here, as it seems to mess with native-image.
Required as we're using a Java 16-based GraalVM on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.