Provide proper logger for using directives plus Tweaking #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
tweaking
branch
3 times, most recently
from
db2550c
to
8965306
Compare
This is useful when developing on any of the stubs modules (stubs, runner, test-runner), but this triggers a recompilation of build very often. This is now disabled by default. When developing on the stubs modules, set `local-repo`.developingOnStubModules to true in build.sc, for Mill's watch mode to take into account changes in them.
alexarchambault
force-pushed
the
tweaking
branch
from
8965306
to
7aa1db7
Compare
Their values are not used during compilation or by Bloop, so no need to use them to make Bloop working directories unique.
alexarchambault
force-pushed
the
tweaking
branch
from
7aa1db7
to
e43844d
Compare
alexarchambault
force-pushed
the
tweaking
branch
from
a118f46
to
557355c
Compare
romanowski
reviewed
Feb 9, 2022
| * set this to true, so that Mill's watch mode takes into account changes in those modules | ||
| * when embedding their JARs in the Scala CLI launcher. | ||
| */ | ||
| def developingOnStubModules = false |
There was a problem hiding this comment.
Should we add similar comment to ReadME.md?
romanowski
reviewed
Feb 9, 2022
There was a problem hiding this comment.
We can apply my comments in the follow up. The only problem I see is that it will conflict with #639
| val directive: StrictDirective | ||
| ) extends BuildException( | ||
| s"Expected a value for directive ${directive.key}", | ||
| positions = Nil // I wish using_directives provided the key position… |
There was a problem hiding this comment.
Directives provide positions so it is a matter of wiring it up
romanowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are small adjustments / refactorings, that I made while working on adding a
publishcommand.