Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/no ref/sb snapshots #15

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

mwleklinski
Copy link
Collaborator

Added SB snapshots checks on CI

@mwleklinski mwleklinski temporarily deployed to development July 27, 2023 08:18 — with GitHub Actions Inactive
@mwleklinski mwleklinski temporarily deployed to development July 27, 2023 11:00 — with GitHub Actions Inactive
@mwleklinski mwleklinski temporarily deployed to development July 28, 2023 08:01 — with GitHub Actions Inactive
@mwleklinski mwleklinski temporarily deployed to development July 28, 2023 08:48 — with GitHub Actions Inactive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So all the time,. when we want to check/generate snapshot we have to create .mdx? Could we make some auto-wrapper for all cases? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noo, Absolutely, I just moved Story in Button to be inside the docs as we discussed earlier

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We lost props table at Docs:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like to have controls inside docs it can be done, but it takes some work to do, we can always revert it do Stories as it was

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need it, it's super useful, to copy whole props config in complex components.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename it to Button.docs.tsx?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existance of this file depends on your answers in the rest of comments ;D

Copy link
Collaborator

@adrian-potepa adrian-potepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs some improvements.

Copy link
Collaborator

@adrian-potepa adrian-potepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stories shout contains docs page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants