Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table id should not be final #95

Merged
merged 1 commit into from Nov 5, 2018
Merged

table id should not be final #95

merged 1 commit into from Nov 5, 2018

Conversation

MarkRBM
Copy link
Contributor

@MarkRBM MarkRBM commented Nov 5, 2018

No description provided.

@MarkRBM MarkRBM mentioned this pull request Nov 5, 2018
Closed
@MarkRBM
Copy link
Contributor Author

MarkRBM commented Nov 5, 2018

sbt scalastyle clean coverage test unidoc "project unicorn-core" +test passes locally for me so not sure how to recreate the build failure

@liosedhel
Copy link
Member

Right, one flaky test, unfortunately. Merging.

@liosedhel liosedhel merged commit c4992f9 into VirtusLab:v1.2.x-slick-3.2.x Nov 5, 2018
@MarkRBM
Copy link
Contributor Author

MarkRBM commented Nov 5, 2018

awesome thanks, when might this get onto sonatype?

@MarkRBM MarkRBM deleted the removeFinalDef branch November 5, 2018 21:53
@liosedhel
Copy link
Member

Should be now, version 1.2.1. Enjoy! (Although sonatype is super slow today, so you might need to wait till tomorrow).

@MarkRBM MarkRBM mentioned this pull request Nov 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarkRBM @liosedhel