Add parsing of .NET user types from .NET metadata stream #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plusvic
reviewed
Jan 10, 2022
|
Thanks for the feedback! Sorry for the delay, I was finishing the last few exams past week. |
HoundThe
force-pushed
the
dotnet_classes
branch
from
a5a3f9e
to
52c145f
Compare
|
I've noticed the test failing on misaligned load and changed the reading functions to work byte-by-byte. |
|
I sent a PR to your branch with a proposal for fixing the same issues: HoundThe#1 I prefer using the |
* Fix unaligned memory access. * Add missing comma in Bazel file.
|
Oh thanks, I didn't notice the PR on my fork, didn't get any notifications about it. I've undone my commit and merged your PR, didn't know about |
plusvic
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces parsing of the user-defined types from the .NET metadata tilde stream. It extracts class names, base types, modifiers, methods with their return types. arguments, etc. (more in the docs). I've been testing the modification with IL/DnSpy and RetDec.
For better code readability and maintainability, as it includes many string concatenations, I've created a simple string-like type in the libyara, that allows me to work with variable strings.
I've also noticed that Bazel tests do not include
test-dotnet.c. I wasn't sure why, so I've included it.I've also included some binary with .NET user type metadata to have something to write tests with, I am not sure what the policy is with including another binary to the testing sample.