Fixed dotnet module failure on Windows #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
metthal
changed the title
metthal
force-pushed
the
dotnet-strdup-fix
branch
from
bc8c917
to
136e8c8
Compare
create_full_name() used strdup() even on Windows where all str* functions are masked behind yr_str*() functions which internally used HeapAlloc()/HeapFree() which does not cooperate well with malloc()/free().
metthal
force-pushed
the
dotnet-strdup-fix
branch
from
136e8c8
to
8a95fe6
Compare
plusvic
approved these changes
Mar 29, 2023
plusvic
pushed a commit
that referenced
this pull request
Mar 29, 2023
create_full_name() used strdup() even on Windows where all str* functions are masked behind yr_str*() functions which internally used HeapAlloc()/HeapFree() which does not cooperate well with malloc()/free().
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_full_name() used strdup() even on Windows where all str* functions are masked behind yr_str*() functions which internally used HeapAlloc()/HeapFree() which does not cooperate well with malloc()/free().
Thanks to @wxsBSD & @tlansec for finding the bug.