Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update rawData? #1780

Closed
KiddoV opened this issue May 23, 2024 · 6 comments · Fixed by #1791
Closed

How to update rawData? #1780

KiddoV opened this issue May 23, 2024 · 6 comments · Fixed by #1791
Assignees

Comments

@KiddoV
Copy link

KiddoV commented May 23, 2024

Related to: #1635

@fangsmile fangsmile self-assigned this May 24, 2024
@fangsmile fangsmile linked a pull request May 24, 2024 that will close this issue
21 tasks
@KiddoV
Copy link
Author

KiddoV commented Jun 6, 2024

I don't think this works as expected yet.

The rawData or rawRecord in general should only update after the updateRecords() method is called.

In the current behavior (version v1.1.0), editing a cell changes the raw record immediately, even without calling updateRecords(). After editing a cell, calling getCellRawRecord() returns the record with the updated cell value, which is incorrect.

The raw record should remain unchanged until updateRecords() is called. That is my point.

I hope this makes sense.

@KiddoV
Copy link
Author

KiddoV commented Jun 17, 2024

@fangsmile Any update on this one?

@fangsmile
Copy link
Contributor

your opinion is right. you can debug code find problem ,further more you can fix it.
Recently, my energy has been limited @KiddoV

@KiddoV
Copy link
Author

KiddoV commented Jun 17, 2024

Will try my best then...

@fangsmile
Copy link
Contributor

You can record in the issues, in case you forget

@KiddoV
Copy link
Author

KiddoV commented Jun 18, 2024

@fangsmile I am not sure how can I modify the source code locally and import to my project for testing.
I have tried: npm i \path\to\local\VTable\packages\vtable.
Everything seem to be broken when I run my app.

Can u guide me to the right direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants