Replace cell widgets by pixmaps while dragging on overlays #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crashes on Windows when VTK is involved 😢 (version: 5.10.0) |
|
This is what I mean by "flicker": https://googledrive.com/host/0B3ucPz7GSthBTE81eUo3eGhlWk0 |
|
that's a very strange behavior. On Tue, Jun 9, 2015 at 4:46 PM, Remi Rampin notifications@github.com
|
remram44
force-pushed
the
use-pixmaps-when-dragging-rbs
branch
2 times, most recently
from
9d1f3dd
to
d881733
Compare
Somehow, this doesn't fix the issue.
VTK will fail to render with "invalid drawable" if its widget is unparented first.
Also contains fix for "invalid drawable"
If the plot gets the drag focus first it creates a focus change between the plot and the cell container. This caused a dragExit event each time the mouse was moved. Setting transparentForMouseEvents on currentWidget when creating fake widget seems to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Please check everywhere. Also the code doesn't look great, might warrant some cleaning/factoring.