New ddw #1005
Closed
New ddw #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto uvcdat-master
…had before. I have no clue about why, but if you let it try, it will crash. These changes make sure that animations don't happen.
…ead. This should make it clear that that class is part of a workaround to a GUI bug (if you clear a cell, the contents don't change visibly, although they do get cleared internally) and no more. Also, the other changes check for None. 2. When the spreadsheet cell (graphics pane) should be blank, we now: (1) call clear_cell on it (2) make a uvc_zero_plotspec (a pseudo-blank plot) and plot it (3) call clear_cell on it again This change seems to reduce but not eliminate the possibility that you'll get a segfault upon clicking on a blank pane (the click should just select it for use in the menu on top, and draw a blue highlight to confirm your selection). I've run out of workarounds. To do any better, we'll have to fix the Vistrails GUI which all this is built on top of.
…ching a bogus file)
Conflicts: vistrails/gui/uvcdat/diagnosticsDockWidget.py
…grid' into uvcdat-master
Disallow vtkWebApplication as a module and catch NotImplementedErrors for abstract class. Also update vtk_parser.py to include Prabhu's updates for VTK6.
…nd do so). Also, some useless debugging output is deleted.
Fix QStrings from filechoosers
Fixes a traceback on cell creation
There is no way this worked with names that don't contain a dot (NameError).
Fixes an UnboundLocalError
Fix vtk package seems to fix the vtk load error, still get the InputPort error though, but that's another issue
Fix vtkcell on X11 for VTK >=6.2
fixes issues due to outline/outfill no being part of vcs anymore
Uvcdat vcs3 d features for v2.1.1
changes for GUI for diagnostics code rework
… but I can't claim to know what the changes are.
|
Filed against the wrong fork again... I'll see with github what they can do, this keeps happening. |
Merged
|
Thanks for fixing this. I don't know how it got into the Vistrails main fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes came from Brian. Here's what he had to say: "I’ve got a patch that handles properly updating the variables list regardless of the selection order by the user."
I've put it through my usual tests and some more, and everything works normally.