Uvcdat 911 colormap editor issues #968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cell toolbar now uses the save_formats attribute from the cell widget to show the export dialog. This means there is no need to create a custom toolbar only to add export formats. Conflicts: vistrails/packages/tabledata/viewer.py
Renames the file from gui/resources/images/ to spreadsheet/images/ Puts it in spreadsheet's cell_rc.py instead of VTK's vtkcell_rc.py. Removes vtkcell_rc.py because it would now be empty. Conflicts: vistrails/packages/vtk/vtkcell_rc.py vistrails/packages/vtk/vtkviewcell.py
Somehow I hadn't seen this file. Conflicts: vistrails/packages/spreadsheet/cell_rc.py vistrails/packages/spreadsheet/celltoolbar.qrc vistrails/packages/spreadsheet/celltoolbar_rc.py
On trying to save an empty cell, QPromptCellWidget throws an exception because it does not have the save_formats field so we now check that we have an instance of QCellWidget.
Since the export sheet menu is confusing and likely to be used rarely, we move it to be a submenu of the UV-CDAT options menu.
…wc_x1,datawc_y2,etc.)
…2-separate-file-types_release'
… into uvcdat-master
…release' into uvcdat-master
…elease' into uvcdat-master
These classes can't simply instantiated which is done as part of the registration process. So exclude them from this to prevent warnings/errors.
…rk security. The GUI menu is improved, notably so that data set choices are minimized until you decide to use them. Also Brian restored my (Jeff's) crude system for blanking out old plots.
…, minor print improvements.
…isplay a legible plot title line more often. This is very much the wrong way to do it, but will make things more tolerable until we do it better.
…g a diags plot. Reverting the email-induced ^Ms in diagnosticsDockWidget.py as well
…or' into uvcdat-master
…rmap-show-buttons
…f vistrails.org:vistrails into uvcdat-issues-830-682-681-save-colormap-show-buttons
… nothing had ever looked at what the user wanted, it always had the default value) and set the appropriate file filter.
Uvcdat 520 fix packages
…ated for observations.
…ts) #1 (i.e. DS1). It's been around for months but ignored until now. The way I did it is crude but effective. We may want to drop this and do it like obs datasets in the future. Or maybe do something completely different.
In applyClicked, look at what obs set the user had chosen (previously no...
…ormap-show-buttons Uvcdat issues 830 682 681 save colormap show buttons since @remram44 is good with it and nobody seems to have time to do anything about this. self-merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committed code for 911: CDAT/cdat#911
Please approve and merge.