Skip to content
This repository has been archived by the owner on Jul 18, 2022. It is now read-only.

Reimplement URLPattern as str subclass #14

Merged
merged 2 commits into from Aug 4, 2017
Merged

Reimplement URLPattern as str subclass #14

merged 2 commits into from Aug 4, 2017

Conversation

Suor
Copy link
Contributor

@Suor Suor commented Aug 4, 2017

This has some advantages:

  • it's now usable outside urljects helpers such as Django url() or really anywhere
  • code is cleaner
  • fixes mutability bug

On last one: now you modify parts, which can lead to unexpected behavior:

base_url = U / 'base'
u1 = base_url / '1'
u2 = base_url / '2'  # now it's /base/1/2

@Visgean Visgean merged commit eafcaf6 into Visgean:master Aug 4, 2017
@Visgean
Copy link
Owner

Visgean commented Aug 4, 2017

I will make a new release in couple of days.

@Visgean
Copy link
Owner

Visgean commented Aug 28, 2017

Relased. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants