Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry-Effect-Interface Project #238

Merged
merged 14 commits into from Mar 20, 2021
Merged

Blurry-Effect-Interface Project #238

merged 14 commits into from Mar 20, 2021

Conversation

gaurav24072002
Copy link
Contributor

Related Issue

  • Separated the .html file in public folder , .css and .js in assest folder.
  • allow this project edit by maintainers.

Closes: #225 , #169

Describe the changes you've made

  • Separated the .html file in public folder , .css and .js in assest folder.
  • allow this project edit by maintainers.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Screenshots

BEFORE -
Screenshot (107)

AFTER -
Screenshot (108)

@gaurav24072002
Copy link
Contributor Author

@urvashi-code1255 and @Vishal-raj-1 now is this good to go.. I have solved the issues.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaurav24072002 Add your project details in script.js

Also pull the recent changes.

@gaurav24072002
Copy link
Contributor Author

ok sure ...

Added the project details in blurry_loading_interface.js file.
@gaurav24072002
Copy link
Contributor Author

Please review it and tell me if some more changes are required or not.
Thank you @urvashi-code1255 for reviewing my commits as well.

// The main brain of the body that is how will the opacity change from 100% to 0% is written under this javascript file that is blurry_loading_interface.js file.
// You can use this repository to add a starter page to your website and showcase it to your friends or for company basis as well.
// Thank you guys for viewing this project...
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tell me if I need to add more details to it or not like telling how the code base works and all that stuffs...

@gaurav24072002
Copy link
Contributor Author

@urvashi-code1255 and @Vishal-raj-1 can you please merge my pull request and add tag of gssoc '21 on it so that it could be counted in gssoc '21 ..and Please tell me if further changes are to be made in it or not.. thank you..

@gaurav24072002
Copy link
Contributor Author

and please assign me this project in assignee section 😅

@gaurav24072002
Copy link
Contributor Author

@urvashi-code1255 Any Suggestions that I need to do to improve it ??

@gaurav24072002
Copy link
Contributor Author

Any Updates for this issue ??

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaurav24072002 You don't have to put your project details like this.

Open script.js once and see that every project is described there in some points like gif, name etc.

@gaurav24072002
Copy link
Contributor Author

Ya sure I got it ...

@gaurav24072002
Copy link
Contributor Author

Now is It Good to go ?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaurav24072002 Add GIF of your project!!

Also remove the horizontal and vertical scroll bar from your project

@gaurav24072002
Copy link
Contributor Author

ok

@gaurav24072002
Copy link
Contributor Author

Now is it good to go?

@gaurav24072002
Copy link
Contributor Author

Can you Please assign this to me under assignee and Please add the tag of GSSOC '21 on it..😅

@ghost
Copy link

ghost commented Mar 19, 2021

@gaurav24072002 Please resolve the merge conflicts again

@gaurav24072002
Copy link
Contributor Author

@urvashi-code1255 I have resolved the merge conflicts. Please merge it 😄

@gaurav24072002
Copy link
Contributor Author

@urvashi-code1255 any Update ?

@ghost
Copy link

ghost commented Mar 20, 2021

@gaurav24072002 Resolve it again.

@gaurav24072002
Copy link
Contributor Author

Hey! @urvashi-code1255 I have been working with other projects also but they didn't took so much of time to merge an issue.
you are just again and again making me resolve conflicts. Please merge this time. and please add tag of Gssoc '21 to it and level tag.

Copy link
Contributor

@ridsuteri ridsuteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work @gaurav24072002 ,thanks for contributing :)

@ridsuteri ridsuteri merged commit a6c28aa into Vishal-raj-1:main Mar 20, 2021
@gaurav24072002
Copy link
Contributor Author

Thank you so much @ridsuteri 👍

@ridsuteri
Copy link
Contributor

@gaurav24072002 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants