Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry Loading Interface #169

Closed
wants to merge 2 commits into from
Closed

Blurry Loading Interface #169

wants to merge 2 commits into from

Conversation

gaurav24072002
Copy link
Contributor

@gaurav24072002 gaurav24072002 commented Feb 26, 2021

Hey !!
I am a participant in Girl Script Summer of Code and want to contribute in this project.
can you assign this project to me !

Hey !!
I am a participant in Girl Script Summer of Code and want to contribute in this project.
can you assign this project to me !
@Vishal-raj-1
Copy link
Owner

sure

@ghost
Copy link

ghost commented Feb 27, 2021

Hey @gaurav24072002 Open an issue for your project first!!

Also do follow the PR template and add UI picture/video

@gaurav24072002
Copy link
Contributor Author

@urvashi-code1255 there is no issue for this project but I just wanted to contribute in this repository so please merge my pull request... ok

@ghost
Copy link

ghost commented Feb 27, 2021

@urvashi-code1255 there is no issue for this project but I just wanted to contribute in this repository so please merge my pull request... ok

Hey @gaurav24072002 then also you have to follow rules of the repository... right!!

Which means before making any PR you should first raise an issue explaining about it.

@gaurav24072002
Copy link
Contributor Author

ok...
sure thanks...

@gaurav24072002
Copy link
Contributor Author

done ...
Is that ok ? ..

Copy link
Owner

@Vishal-raj-1 Vishal-raj-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaurav24072002 Follow structure of the projects. Make seperate css, js file. Second enable github pages on your local forked repo so that I can see your changes and review it clearly.

@ghost
Copy link

ghost commented Mar 1, 2021

Hey @gaurav24072002 Any updates on this PR?

@gaurav24072002
Copy link
Contributor Author

@Vishal-raj-1 can you please describe briefly about what I have to do Please...

@Vishal-raj-1
Copy link
Owner

@gaurav24072002 I mean You have make a single file. Break this file into 3 files namely blurry_loading_interface.html , blurry_loading_interface.css, blurry_loading_interface.js .

Second Now Do one more thing, enable github pages, so I can review your changes before merging to this codebase.

@gaurav24072002
Copy link
Contributor Author

sure I will do it

This was referenced Mar 5, 2021
@ghost ghost closed this Mar 21, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants