Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev pranjal posix #110

Merged
merged 10 commits into from
Feb 19, 2022
Merged

Dev pranjal posix #110

merged 10 commits into from
Feb 19, 2022

Conversation

pranjalchanda08
Copy link
Contributor

@pranjalchanda08 pranjalchanda08 commented Feb 19, 2022 •
edited by akashkollipara
Loading

  • Add Pthread base support
  • Add call_arg type for mcall and scall

@pranjalchanda08 pranjalchanda08 added enhancement Upgrading feature or request cyancore framework Cyancore framework feature request FR Add new feature or request bug-critical System failure can be predicted labels Feb 19, 2022
@pranjalchanda08 pranjalchanda08 added this to the Release #3 v2.2.1 milestone Feb 19, 2022
@pranjalchanda08 pranjalchanda08 self-assigned this Feb 19, 2022
This was linked to issues Feb 19, 2022
FR: Add support for unified POSIX framework to support multiple kernel support to CC #89
Open
BUG: unsigned int is not enough for passing pointers to machine_call #109
Closed
akashkollipara
akashkollipara reviewed Feb 19, 2022
View reviewed changes
src/include/call_type.h Outdated
#pragma once

#if defined(ARCH_ARM_32)
typedef unsigned long call_args;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved to core header file...
This will auto typedef. Anyways we have that header file in place for core specific functions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure

akashkollipara
akashkollipara reviewed Feb 19, 2022
View reviewed changes
src/include/call_type.h Outdated
@@ -0,0 +1,21 @@
/*
* CYANCORE LICENSE
* Copyrights (C) 2019, Cyancore Team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022 Year :)

@sonarcloud
Copy link

sonarcloud bot commented Feb 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

akashkollipara
akashkollipara approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@akashkollipara akashkollipara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akashkollipara akashkollipara merged commit 2ca60fe into dev_cc_kernel Feb 19, 2022
@akashkollipara akashkollipara deleted the dev_pranjal_posix branch February 19, 2022 10:28
@pranjalchanda08 pranjalchanda08 restored the dev_pranjal_posix branch February 19, 2022 10:29
@akashkollipara akashkollipara deleted the dev_pranjal_posix branch February 19, 2022 10:31
@pranjalchanda08 pranjalchanda08 restored the dev_pranjal_posix branch February 19, 2022 10:44
@pranjalchanda08 pranjalchanda08 deleted the dev_pranjal_posix branch February 19, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashkollipara akashkollipara akashkollipara approved these changes

Assignees

@pranjalchanda08 pranjalchanda08

Labels
bug-critical System failure can be predicted cyancore framework Cyancore framework feature request enhancement Upgrading feature or request FR Add new feature or request
Projects
None yet
Milestone
No milestone
2 participants
@pranjalchanda08 @akashkollipara