Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<libresource> Add new macros to create SP and DP #268

Merged
merged 2 commits into from
Jan 4, 2024
Merged

<libresource> Add new macros to create SP and DP #268

merged 2 commits into from
Jan 4, 2024

Conversation

akashkollipara
Copy link
Member

No description provided.

@akashkollipara akashkollipara force-pushed the dev/akashkollipara/256-libresources-update branch from e0213d3 to c7314c6 Compare January 4, 2024 06:42
@akashkollipara akashkollipara force-pushed the dev/akashkollipara/256-libresources-update branch from c7314c6 to eab0cc5 Compare January 4, 2024 14:51
@akashkollipara akashkollipara self-assigned this Jan 4, 2024
@akashkollipara akashkollipara marked this pull request as ready for review January 4, 2024 14:51
@akashkollipara akashkollipara added documentation Improvements or additions to documentation terravisor Terravisor related issue cyancore framework Cyancore framework feature request FR Add new feature or request bug-critical System failure can be predicted labels Jan 4, 2024
@akashkollipara akashkollipara added this to Review in Terravisor via automation Jan 4, 2024
@akashkollipara akashkollipara added this to the Boron milestone Jan 4, 2024
@akashkollipara akashkollipara linked an issue Jan 4, 2024 that may be closed by this pull request
Clean up SP and DP code using Macros #256
Closed
@akashkollipara akashkollipara changed the title First Draft of DP and SP cleanup <libresource> Add new macros to create SP and DP Jan 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 4, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
17.8% Duplication on New Code

See analysis details on SonarCloud

@pranjalchanda08
Copy link
Contributor

@akashkollipara please fix the sonar cloud issue

@akashkollipara akashkollipara merged commit 38b1813 into development Jan 4, 2024
5 checks passed
Terravisor automation moved this from Review to Done Jan 4, 2024
@akashkollipara akashkollipara deleted the dev/akashkollipara/256-libresources-update branch January 4, 2024 16:24
@akashkollipara
Copy link
Member Author

@akashkollipara please fix the sonar cloud issue

Done...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranjalchanda08 pranjalchanda08 pranjalchanda08 approved these changes

@shubhangi47 shubhangi47 Awaiting requested review from shubhangi47

@MayuriLokhande MayuriLokhande Awaiting requested review from MayuriLokhande

Assignees

@akashkollipara akashkollipara

Labels
bug-critical System failure can be predicted cyancore framework Cyancore framework feature request documentation Improvements or additions to documentation FR Add new feature or request terravisor Terravisor related issue
Projects
Terravisor
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up SP and DP code using Macros
2 participants
@akashkollipara @pranjalchanda08