Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for using phpunit.xml files #157

Closed
wants to merge 1 commit into from
Closed

Implement support for using phpunit.xml files #157

wants to merge 1 commit into from

Conversation

dawehner
Copy link

Solves #156

@codecov-io
Copy link

Current coverage is 3.72%

Merging #157 into master will decrease coverage by 0.29%

@@            master      #157   diff @@
========================================
  Files           13        13          
  Lines          498       537    +39   
  Methods         44        46     +2   
  Messages         0         0          
  Branches         0         0          
========================================
  Hits            20        20          
- Misses         478       517    +39   
  Partials         0         0          

Powered by Codecov. Last updated by 4598df6...c297c2e

@localgod
Copy link
Member

Thanks for the pull request. Support for phpunit.xml files is a valuable addition.
I can not seem to activate your addition no mater where I put my phpunit.xml file. Could you expand your pull request by adding a sample setup? I would expect vpu to parse a phpunit.xml file located in /tests with below content to exclude ExpectedFailureTest.php however this dos not seem to happen.
`

<testsuites>
    <testsuite name="VisualPhpUnit test suite">
        <directory>./</directory>
        <exclude>./ExpectedFailureTest.php</exclude>
    </testsuite>
</testsuites>

`
Could also be I have misunderstood how your code should work.

@localgod
Copy link
Member

Closing this one as there has been no follow up for some time.

@localgod localgod closed this Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants