Add movie file, add_movie and list_movies methods #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoyon
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
@diegoyon approved this pull request.
Hi @VitorGuedesMadeira ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations!
Highlights
Descriptive Pull request heavy_check_mark
Good use of Gitflow heavy_check_mark
Commits are meaningful heavy_check_mark
Basic structure of the repo is excellent;
README file is great;
Clean code heavy_check_mark
All card requirements are OK heavy_check_mark
Cheers and Happy coding!clapclapclap
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
This was
linked to
issues
Oct 10, 2022
This was
unlinked from
issues
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Movie class
Add can_be_archived?() in the Movie class
Implemented: