Fixed an oversight in which a remap changes an opcode. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitorVilela7
requested changes
Oct 31, 2019
There was a problem hiding this comment.
HI MFG, thank you for submitting the patch! I have checked it and it indeed fixes the issue.
There is only one minor detail that would need to be adjusted: since it changes the remapping patches and they are only applied once (there's an if around all org commands checking if it's a clean ROM or not), you have to as well add an if at the top of the file checking if the opcode at $00:977C is the STA opcode and if so, apply that particular change so non-clean ROMs can get the fix as well.
|
Remaining changes will be made myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An oversight which went unnoticed until now (changed layer 3 tilemap which is invisible unless on a custom Game Over) is where the STZ at $00977C is changed to STA.