This repository has been archived by the owner on May 24, 2023. It is now read-only.
Typo correction for #62 #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not a typo. http://golang.org/pkg/database/sql/#Rows.Err |
|
@xaprb it's not a typo, but it can be misunderstood as one. The text directly below talks about |
|
OK. Probably got all mixed up while I was rewriting a bunch of this. Will take a look later. |
|
Ah, I think I see now. It looks like it may become 2 sections; Errors From Iterating Resultsets and Errors From Close. Bad pull request. My apologies. |
Closed
|
I pushed a branch with my proposed changes in #63. Review |
|
Looks good to me. I was previously unaware of rows.Err() so I need to go back and modify some code. Thanks again for a great tutorial! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.