Skip to content

Commit

Permalink
Removed WIP and Code-Review -2 from waiting for reviewer metric.
Browse files Browse the repository at this point in the history
  • Loading branch information
Alvaro del Castillo committed Sep 13, 2014
1 parent 7017bee commit 8fe792f
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions vizgrimoire/metrics/scr_metrics.py
Expand Up @@ -347,6 +347,8 @@ def get_pending(month, reviewers = False):
filters += " AND i.id = ch.issue_id AND t1.id = ch.id"
# last change should move responsibility to reviewer
filters += " AND NOT (ch.field = 'Code-Review' AND ch.new_value = '-1')"
filters += " AND NOT (ch.field = 'Code-Review' AND ch.new_value = '-2')"
filters += " AND summary not like '%WIP%' "

q = self.db.GetSQLGlobal('i.submitted_on', fields, tables, filters,
startdate, enddate)
Expand Down Expand Up @@ -399,6 +401,8 @@ def _get_sql(self, evolutionary):
filters = """
i.id = ch.issue_id AND t1.id = ch.id
AND NOT (ch.field = 'Code-Review' AND ch.new_value = '-1')
AND NOT (ch.field = 'Code-Review' AND ch.new_value = '-2')
AND summary not like '%WIP%'
"""

filters = filters + self.db.GetSQLReportWhere(self.filters.type_analysis, self.db.identities_db)
Expand All @@ -409,6 +413,7 @@ def _get_sql(self, evolutionary):
return(q)


# Review this metrics according to ReviewsWaitingForReviewer
class ReviewsWaitingForSubmitter(Metrics):
id = "ReviewsWaitingForSubmitter"
name = "Reviews waiting for submitter"
Expand Down

0 comments on commit 8fe792f

Please sign in to comment.