#28 edit chart menu #315

cameronjtoy · 2024-04-26T16:28:36Z

Changes:
UI is reflected in the new v2.0 Figma UI, which can change Chart Customization or Line Customization.
UI includes Category in frontend
Filter Parameter now includes a dropdown for numerical values to be specific with what is being filtered, not just the x-axis.
All types of chart types are handled in the ChartEditor class
The number of rows for Line Customization is determined by (dataset * ys * categories)
New Color Parameter to select color for lines/points/bars

Changes: - Profiler is now moved to Artifact.scala. - Added info.vizierdb.profiler package. - Artifact.updateDatasetProperty now includes "is_profiled" as a property.

Debrief: In Artifact.scala, a property was added to the artifact using updateDatasetProperty. - if "is_profiled" is not a property then it will be attached to the artifact. - if "is_profiled" is a property then the profiler will run ONLY IF it is set to the boolean FALSE. Once the profiler runs then the profiled information is then set to the value of the property "is_profiled". This will prevent the profiler from running multiple times on a single dataset. *TEST CASES*: Test cases are held in PublishArtifactSpec.scala. You must run the whole PublishArtifactSpec.scala otherwise the second profiler test case will fail. It will fail since the profiler has not been set as a property (which is done in the first profiler test case).

Changed datasetProperty so "Is_profiled" would be connected to the jsonObject. No longer determined by boolean. (**Only Temporary, will get changed so "is_profiled" is back to boolean**)

forceProfile parameter in describe and in datasetData is now set to True

"is_profiled" and profiler properties are now added to Artifact. Tests are now more accurate and test for correct information.

…ted ListObjects, Made some adjustments towards Backend towards fixing multiple Y-axis implementation

yIndex from Int -> Seq[Int]

VegaChart Change: added Offset between bars. PlotUtils: Handles a Sequence of Y's correctly BarChart: Adjusted to handle multiple Y's

into New-Interface

…ier-scala into #28-Edit-Chart-Menu

okennedy

Main observations

Drop the new parameter types, as noted in the comments. I encourage you to factor the rendering code out into info.vizierdb.ui.widgets, but many of them don't need to be new parameter types. (Multiselect is a legitimate new use-case)
Delete all the build-specific crap that's getting committed. That doesn't belong in a build tree
Fix ChartEditor.loadState

okennedy · 2024-05-01T00:41:05Z

vizier/backend/src/info/vizierdb/Vizier.scala

@@ -167,14 +167,6 @@ object Vizier
    }
  }



Why is a commit to the plotting tools making changes to Vizier.scala?

okennedy · 2024-05-01T00:43:54Z

vizier/backend/src/info/vizierdb/catalog/Artifact.scala

@@ -291,6 +323,7 @@ case class Artifact(
    datasetDescriptor.properties.get(name)
  }



spurious extra space?

okennedy · 2024-05-01T00:47:11Z

vizier/backend/src/info/vizierdb/commands/Parameter.scala

+}
+
+case class ColorParameter(


Why does this need to be a brand new parameter type? It seems like this could be a string parameter, just with a new frontend.

Specifically, Parameter types are part of the formal Vizier Frontend/Backend API. Adding a new parameter commits Vizier to supporting it in the long term. This makes extensibility far more difficult and painful. Before adding a new parameter (rather than a new frontend for an existing parameter), we need to ask whether the new parameter is strictly needed.

okennedy · 2024-05-01T00:47:41Z

vizier/backend/src/info/vizierdb/commands/Parameter.scala

+
+
+case class AggregateParameter(


AggregateParameter could be an enum parameter

okennedy · 2024-05-01T01:18:05Z

vizier/backend/src/info/vizierdb/commands/plot/BarChart.scala

            range = Some(VegaRange.Category),
-            domain = Some(VegaDomain.Literal(series.names.map { JsString(_) }))
+            domain = Some(VegaDomain.Literal(yAxisLabels.map(JsString(_))))


Discussed today. Revert this change back to series.

okennedy · 2024-05-01T01:35:26Z

vizier/ui/src/info/vizierdb/ui/components/ChartEditor.scala

+
+    override def currentState: Seq[CommandArgument] = 
+    {
+    println(datasetRows.now)


see note about logger.

okennedy · 2024-05-01T01:39:22Z

vizier/ui/src/info/vizierdb/ui/components/CommandList.scala

@@ -209,10 +209,10 @@ object CommandList
    ),
    "Visualize" -> Seq(
      SpecialCommand(label = "Line",        icon = "line_plot",    packageId = "plot", commandId = "line-chart", description = "Visualize datasets as a a series of lines (with or without points)"),
-      SpecialCommand(label = "Scatterplot", icon = "scatter_plot", packageId = "plot", commandId = "scatterplot", description = "Visualize datasets as a series of colored points"),
+      SpecialCommand(label = "Scatterplot2.0",    icon = "scatter_plot", packageId = "plot", commandId = "scatterplot", description = "Visualize datasets as a series of colored points"),


Drop the 2.0

okennedy · 2024-05-01T01:39:44Z

vizier/ui/src/info/vizierdb/ui/components/ScatterPlotEditor.scala

Delete empty file

okennedy · 2024-05-01T01:40:29Z

vizier/ui/src/info/vizierdb/ui/components/dataset/Dataset.scala

@@ -62,8 +66,21 @@ class Dataset(
                    fetchRowsWithAPI, 
                    (candidates, pageSize) => candidates.maxBy { pageIdx => math.abs(pageIdx - table.firstRowIndex) }
                  )
+  val datasetSummary = new DatasetSummary(projectId, datasetId)                


This should be an Rx. Don't use raw dom manipulation if avoidable.

okennedy · 2024-05-01T01:41:10Z

...er/ui/src/info/vizierdb/ui/widgets/out/mill-worker-vrMkfQzgGvpDuso79873Fe0Y3gw=-1/clientLock

Again... don't commit this garbage.

…tegorical and numerical

JasonMai11 and others added 30 commits October 17, 2023 21:10

Profiler Changes

7340ba6

Changes: - Profiler is now moved to Artifact.scala. - Added info.vizierdb.profiler package. - Artifact.updateDatasetProperty now includes "is_profiled" as a property.

Updating profiler without changing updatedatasetProperty functionality

03a1f0b

datasetProperty Function

85418f0

Changed datasetProperty so "Is_profiled" would be connected to the jsonObject. No longer determined by boolean. (**Only Temporary, will get changed so "is_profiled" is back to boolean**)

Update Artifact.scala

b156ef3

forceProfiler

eddea71

forceProfile parameter in describe and in datasetData is now set to True

Profiler Implementation and Testing

bd70602

"is_profiled" and profiler properties are now added to Artifact. Tests are now more accurate and test for correct information.

Completion of Profiler

17be764

Updated Param List

0165187

#24 Temporary Change for frontend with new Parameter Encoding For nes…

ddb4595

…ted ListObjects, Made some adjustments towards Backend towards fixing multiple Y-axis implementation

yIndex Change

f789c8c

yIndex from Int -> Seq[Int]

ColIDListParameter working

72dcb0a

Bar Chart Editor Changes

279e2d6

new bar chart editor

6c3805a

Update PlotUtils.scala

c8ac19d

empty min error but console has correct info

e4b1c3b

button changes

7f34306

scss changes

65da900

no more empty min

37d5dce

working frontend

f169b10

Update PlotUtils.scala

ff030be

Merge branch 'Vizier-profiler-implementation' into New-Interface

65d0b74

Artifact changes

b25fb10

working frontend

c9aded4

slider and new scss

4895727

Bar Chart implementation

baaeb9d

VegaChart Change: added Offset between bars. PlotUtils: Handles a Sequence of Y's correctly BarChart: Adjusted to handle multiple Y's

Merge branch 'New-Interface' of https://github.com/VizierDB/vizier-scala

9e14d40

into New-Interface

Chart Plotting

e1dc77a

Profile no longer double-nests keys.

bd48fbd

Resetting logging of catalog.Artifact

055b116

eeeeemosewa and others added 17 commits April 23, 2024 01:01

#35 scss table sidemenu 32px margin

40a479d

#35 scss y add del button

bb9f75e

#28-Edit-Chart-Menu - Adding dataset needs the box and headers removed

f157b74

#28-Edit-Chart-Menu - added class names to add and delete buttons

51ba356

#35 scss button changes

45ab8b3

#28-Edit-Chart-Menu - moved icons in front of text

e178fda

Merge branch '#28-Edit-Chart-Menu' of https://github.com/VizierDB/viz…

0892391

…ier-scala into #28-Edit-Chart-Menu

#28-Edit-Chart-Menu - removed text from the buttons

33f38f9

#35 scss remove - y button for first y

e18afd4

#28-Edit-Chart-Menu - populating with multiple ys and datasets

cde685f

#28-Edit-Chart-Menu - added class names to add/delete row buttons

bfb8927

#35 scss to fix color param alignment

85345dc

#35 scss filter slider min and max width

2130871

#35 scss command arg width changes

708f4a8

#35 scss set parameter width to 90px

89b272b

#35 scss command arg width to 90px

2300be5

#35 scss text input width to 82px

61b56d6

cameronjtoy self-assigned this Apr 26, 2024

eeeeemosewa added 2 commits April 26, 2024 16:27

#35 scss hide del row button for first row

a4836ed

#35 scss hide del row button for first row

b9394dc

okennedy self-requested a review May 1, 2024 00:36

okennedy reviewed May 1, 2024

View reviewed changes

cameronjtoy and others added 8 commits May 6, 2024 02:34

#28 - Delete .DS_Store

3c48d06

#28 - Delete .scalafmt.conf

15b43c0

#28 - Migrated out Filter

7f13e1a

#28 - Filter Parameter outside and has case class to differentiate ca…

c51f611

…tegorical and numerical

#28 - color element fix

cd8d06b

#35 scss sizing changes for filter input

14a5d9d

#28 label and color addition change

f531578

#28 Load State Fix for new editor

6a06846

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#28 edit chart menu #315

#28 edit chart menu #315

cameronjtoy commented Apr 26, 2024

okennedy left a comment

okennedy May 1, 2024

okennedy May 1, 2024

okennedy May 1, 2024

okennedy May 1, 2024

okennedy May 1, 2024

okennedy May 1, 2024

okennedy May 1, 2024

okennedy May 1, 2024

okennedy May 1, 2024

okennedy May 1, 2024

		@@ -291,6 +323,7 @@ case class Artifact(
		datasetDescriptor.properties.get(name)
		}

#28 edit chart menu #315

Are you sure you want to change the base?

#28 edit chart menu #315

Conversation

cameronjtoy commented Apr 26, 2024

okennedy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment