Merge pull request #15 from Vizir/fix/filter-axios-error

filter sensitive values in axios error
Vizir · Apr 12, 2022 · 78fbb13 · 78fbb13
2 parents 7313fca + ba10049
commit 78fbb13
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 6 deletions.
diff --git a/src/logger-filter.ts b/src/logger-filter.ts
@@ -47,16 +47,28 @@ export class LoggerFilter {
     return result;
   }
 
+  private isLossLessNumber(value: any): boolean {
+    if (value instanceof LosslessNumber) {
+      return true;
+    }
+
+    if (value?.constructor === Object && value.type === "LosslessNumber") {
+      return true;
+    }
+
+    return false;
+  }
+
   private filterItem(key: string, item: any): any {
     if (this.isOnBlacklist(key) && !this.isOnWhitelist(key)) {
       return this.placeholder;
     }
 
     if (item instanceof Error) {
-      return this.filterError(item);
+      return this.filterObject(this.filterError(item));
     }
 
-    if (item instanceof LosslessNumber) {
+    if (this.isLossLessNumber(item)) {
       return item.value;
     }
 

diff --git a/test/fixtures/axios-error.json b/test/fixtures/axios-error.json
@@ -7,7 +7,8 @@
       "Accept": "application/json, text/plain, */*",
       "Content-Type": "application/json;charset=utf-8",
       "countryId": 1,
-      "User-Agent": "axios/0.19.2"
+      "User-Agent": "axios/0.19.2",
+      "x-api-key": "b6732a5f-a233-49b1-8b23-ef92d8e638ab"
     },
     "baseURL": "https://domain.com",
     "transformRequest": [],

diff --git a/test/logger-filter.spec.ts b/test/logger-filter.spec.ts
@@ -1,6 +1,7 @@
 import { DEFAULT_BLACK_LIST } from "../src/default-black-list";
 import { LoggerFilter } from "../src/logger-filter";
 import faker from "faker";
+import { parse } from "lossless-json";
 
 const DEFAULT_PLACE_HOLDER = "*sensitive*";
 
@@ -155,6 +156,25 @@ describe("LoggerFilter", () => {
     expect(parsed).toStrictEqual(expectedResult);
   });
 
+  it("Should return the original data when losslessNumber is converted to pure object", () => {
+    // Given
+    const key = faker.random.word();
+    const value = faker.datatype.number().toString();
+    const losslessNumberInstance = parse(value);
+    const losslessNumberPureObject = JSON.parse(
+      JSON.stringify(losslessNumberInstance)
+    );
+    const item = { [key]: losslessNumberPureObject };
+    const expectedResult = { [key]: value };
+    const filter = new LoggerFilter();
+
+    // When
+    const parsed = filter.process(item);
+
+    // Then
+    expect(parsed).toStrictEqual(expectedResult);
+  });
+
   it("Should replace into a nested object inside an array", () => {
     // Given
     const key = faker.random.word();
@@ -238,19 +258,29 @@ describe("LoggerFilter", () => {
     expect(parsed.error.name).toBe(expectedResult.error.name);
   });
 
-  it("Should serialize an axios error removing not need attributes", () => {
+  it("Should serialize an axios error removing useless attributes and replacing sensitive content", () => {
     // Given
     // eslint-disable-next-line @typescript-eslint/no-var-requires
     const error = require("./fixtures/axios-error.json");
     error.__proto__ = Error.prototype;
     const item = { error };
     const expectedError = {
       error: {
-        config: error.config,
+        config: {
+          ...error.config,
+          data: {},
+          maxContentLength: error.config.maxContentLength.toString(),
+          timeout: error.config.timeout.toString(),
+          headers: {
+            ...error.config.headers,
+            "x-api-key": DEFAULT_PLACE_HOLDER,
+            countryId: error.config.headers.countryId.toString(),
+          },
+        },
         message: error.message,
         name: error.name,
         response: {
-          status: error.response.status,
+          status: error.response.status.toString(),
           statusText: error.response.statusText,
           headers: error.response.headers,
           data: error.response.data,