Add publications model and management #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsubik
requested changes
Dec 2, 2019
| class PublicationDecorator < Draper::Decorator | ||
| delegate_all | ||
|
|
||
| def title_link |
There was a problem hiding this comment.
You can add file link here too. Take a look at DataUploadDecorator, on Publications show page there should be downloadable link for the file.
|
We gonna have to add more validation rules for things like thumbnails, like image minimum size. Also it could be processed by ImageMagick to a valid size after uploading. This is for other story though. |
|
Yeah, I'll add a task about validations, and added the suggested file_link. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.