Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tpi/home page hero styles #264

Merged
merged 8 commits into from
Mar 13, 2020
Merged

Conversation

rapzo
Copy link
Contributor

@rapzo rapzo commented Jan 29, 2020

No description provided.

@aabdaab
Copy link
Contributor

aabdaab commented Jan 30, 2020

Hey, looking good 👍
Couple of things we need to fix here though.

  1. The hero pictures here are of too low quality; not sure if these are some old ones? We've got a higher quality ones in the assets on Invision (I downloaded them and compared with the ones in repo and they're different)
    image
    ☝️ these ones are pixelized
  2. Also, we've got a homepage pattern in assets that will fix the cover issue that we have now.
    image
  3. Background-color should be different: #2465F5 on designs
  4. The dots pattern for Investors & Supporters should be different too, we probably have a correct one in the assets
  5. Mobile secondary hero; I think we need to remove the padding from the section title on mobile as the title spans through two lines
    image
  6. Mobile secondary hero - could you double-check the spacings? It seems that they are too big, the whole section should fit in the mobile screen.

Copy link
Contributor

@aabdaab aabdaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found couple of mismatches with the design, check my comments ☝️

@@ -40,3 +40,9 @@
html {
scroll-behavior: smooth;
}

body {
@include mobile {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our approach was to have default settings for mobile and then changing it accordingly for desktop 🤔
so, it would be:

body {
  overflow-x: hidden;

  @include desktop { ... styles for desktop... }
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do 👍

@rapzo
Copy link
Contributor Author

rapzo commented Jan 30, 2020

1: I'm using the lowest quality one there, yeah, maybe the 2x should be better as a default, although any
2: that's the pattern right there, but it doesn't play well due to fixed sizes in the svg itself
4: there's no asset for that, the svg logo was the closest i could find

Both scenarios require svg handling. I can go for it but I can't predict the outcome nor the time it will take.

Everything else, damn! That's some sharp eye right there!

@simaob
Copy link
Contributor

simaob commented Mar 12, 2020

Hey @batraisk do you mind picking this PR up, update it with the base branch and address Marta's comments. You might need to ask @faustoperez for some assets that Rui said were missing. If it requires svg handling let's not do it for now. Just the simplest changes! Thanks!

@batraisk
Copy link

@simaob , Of course, I’ll do it now)

@batraisk
Copy link

@simaob , I've finished. check please)

@simaob
Copy link
Contributor

simaob commented Mar 13, 2020

I think we got some issue with the button's colors, they should be blue they are not!

Screenshot 2020-03-13 at 12 02 23

@batraisk
Copy link

fixed

@simaob simaob merged commit e393d8c into develop Mar 13, 2020
@simaob simaob deleted the fix/tpi/home-page-hero-styles branch March 13, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants