Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of fixed-navbar on mobile screens #269

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Fix display of fixed-navbar on mobile screens #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/assets/stylesheets/tpi/_navbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@
@import "colors";
@import "variables";

.tpi__navbar-margin {
margin-top: var(--fixed-navbar-height);

@include desktop {
margin-top: 0;
}
}

.tpi__navbar {
// EDGE workaround: Fix the hovering navbar dropdowns issue: https://github.com/jgthms/bulma/issues/2503
// maybe it's best to use from($desktop) since we use widescreen
Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/tpi.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<%= render "layouts/tpi/banner" %>
</section>

<section class="tpi__navbar">
<section class="tpi__navbar <%= 'tpi__navbar-margin' if @current_user.present? %>">
<%= render "layouts/tpi/header" %>
</section>

Expand Down