Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream publication files until we resolve that differently #270

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

tsubik
Copy link
Collaborator

@tsubik tsubik commented Feb 4, 2020

No description provided.

@tsubik tsubik requested a review from simaob February 4, 2020 18:52
@tsubik
Copy link
Collaborator Author

tsubik commented Feb 4, 2020

That is more a workaround than the real solution though.

@tsubik tsubik added the WIP label Feb 5, 2020
@tsubik
Copy link
Collaborator Author

tsubik commented Feb 5, 2020

Gonna test alternative method of providing direct url to google cloud

@simaob
Copy link
Contributor

simaob commented Feb 5, 2020

Cheers, I'll wait for that!

@tsubik
Copy link
Collaborator Author

tsubik commented Feb 5, 2020

Hmm, I see some problems with just providing direct link to urls. When I attach a new file then the old one is removed from the bucket and the file with new id is uploaded (the old one is still available, weird, not sure for how long). But if someone shares the direct link and then the file will be switched, that's not gonna work as expected. Beside, I don't see filename to be saved as a metadata in google bucket so when downloading the file will have generated unique name, even without extension. That's not good too.

@tsubik
Copy link
Collaborator Author

tsubik commented Feb 5, 2020

I think we might go with streaming for now.

@tsubik tsubik removed the WIP label Feb 5, 2020
@tsubik
Copy link
Collaborator Author

tsubik commented Feb 5, 2020

We might need another controller for uploaded documents.

Copy link
Contributor

@simaob simaob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@simaob simaob merged commit ee32a5b into develop Feb 5, 2020
@simaob simaob deleted the stream-publication-files branch February 5, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants