-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream publication files until we resolve that differently #270
Conversation
That is more a workaround than the real solution though. |
Gonna test alternative method of providing direct url to google cloud |
Cheers, I'll wait for that! |
Hmm, I see some problems with just providing direct link to urls. When I attach a new file then the old one is removed from the bucket and the file with new id is uploaded (the old one is still available, weird, not sure for how long). But if someone shares the direct link and then the file will be switched, that's not gonna work as expected. Beside, I don't see filename to be saved as a metadata in google bucket so when downloading the file will have generated unique name, even without extension. That's not good too. |
I think we might go with streaming for now. |
We might need another controller for uploaded documents. |
37e3c84
to
fbcd5d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
No description provided.