Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/country profile #289

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Feature/country profile #289

merged 3 commits into from
Feb 27, 2020

Conversation

simaob
Copy link
Contributor

@simaob simaob commented Feb 27, 2020

This PR adds three new fields for Geographies metadata, the data file to be used and an import script to import the data. It also enables editing on the backend.

You'll need to migrate the database: bundle exec rails db:migrate
And then you can import the data with: bundle exec rails reimport:geographies_metadata

@simaob simaob requested a review from tsubik February 27, 2020 10:57
@tsubik
Copy link
Collaborator

tsubik commented Feb 27, 2020

Hmm, we can start with that, although not sure if that data should be editable at the backend. I would just add that csv file to the repo and load from there.

@tsubik
Copy link
Collaborator

tsubik commented Feb 27, 2020

Or proxy that from external API.

Copy link
Collaborator

@tsubik tsubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it works fine 👍

@simaob
Copy link
Contributor Author

simaob commented Feb 27, 2020

Some of the data is available on Climate Watch, but not on specific endpoints, and the other data is in downloads from the WB... :/ Not ideal, but I'd start with this for the sake of time.

@simaob simaob merged commit c389ca4 into develop Feb 27, 2020
@simaob simaob deleted the feature/country-profile branch February 27, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants