System tests #303
Merged
System tests #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simaob
approved these changes
Mar 17, 2020
|
|
||
| it 'loads the page' do | ||
| expect(page).to have_text('All Climate Targets') | ||
| expect(page).to have_text('Showing 1993 results') |
There was a problem hiding this comment.
These tests would need to be updated if we change the test dump, right? Not sure if I'm understanding correctly.
There was a problem hiding this comment.
Yes, that's why it's not that great. Although, seeds were not changed for a quite a while
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a couple of simple system tests for public pages. I was thinking if to use Cypress or just capybara for it and for now I decided to go with Capybara.
The tests are run against the database restored from development database dump. To recreate the development database dump just invoke command
bin/rake test:db_dump. That will clear the test database, load the seeds and then dump the whole database into the file and clear it again. I'm wondering if not just use factory bot for this, but I was lazy and tested against development data.The problem here is that development data is not great, and it needs to be improved as there are some missing relations between models and not every part of the system have any example data (maybe by seed_dump of part of production data).
I set the version of
rspec-railto4.0.rcversion as this one seems to fully support Rails6. On the previous version failed test screenshots were blank.I also fixed some links here and there to use slugs and not
id. LawsSector needsslugtoo as climate targets per LawsSector url should be improved, but that could be done in separate PR.