Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date filter updates #320

Merged
merged 7 commits into from
Apr 24, 2020
Merged

Date filter updates #320

merged 7 commits into from
Apr 24, 2020

Conversation

tsubik
Copy link
Collaborator

@tsubik tsubik commented Apr 22, 2020

Date filters update

  • changing time range filter title to Date of last change for both Litigations and Laws
  • fixing time range filter sync with query string (it does not work on prod, it's not showing "x Selected"
  • adding new time range filter for Laws and Policies (Date of law passed, or should I name it Date law passed?)

Should I also add filter for litigation opened events? How to name it if I have to add it?

image

@tsubik tsubik requested a review from simaob April 22, 2020 11:53
@tsubik
Copy link
Collaborator Author

tsubik commented Apr 23, 2020

I'm going to add that extra filter for Litigation cases, why not, it should be quick.

@tsubik
Copy link
Collaborator Author

tsubik commented Apr 23, 2020

Already started lol.

@simaob
Copy link
Contributor

simaob commented Apr 23, 2020

Alright =) do it, it makes sense. I will check the PR later today or tomorrow, need to wrap up some other things in the meanwhile!

@tsubik
Copy link
Collaborator Author

tsubik commented Apr 23, 2020

image

I think this "2 selected", "1 selected" here for TimeRange filter does not make any sense. I will change it to: "From 2013 to 2019", "From 2013", "To 2019"

@simaob
Copy link
Contributor

simaob commented Apr 23, 2020

yeah you're right, makes no sense.

Copy link
Contributor

@simaob simaob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really makes it much more useful and clear. And thanks for the bugfix too! =D

@simaob simaob merged commit b54d2e6 into develop Apr 24, 2020
@simaob simaob deleted the date-filter-updates branch April 24, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants