add document upload to UI for legislations #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowal
reviewed
Aug 22, 2019
| <%= f.input :document_type_ids, label: 'Document', as: :tags, collection: DocumentType.all %> | ||
| <%= | ||
| Arbre::Context.new do | ||
| columns do |
There was a problem hiding this comment.
@tsubik So I've added column layout here without specific requirement, I thought the form will be more compact and easy to scan this way. I guess we can drop columns from here for now until we get more specific details about form UI guidelines.
kowal
reviewed
Aug 22, 2019
| @@ -25,4 +29,15 @@ def litigations_links | |||
| title: litigation.title | |||
| end | |||
| end | |||
|
|
|||
| def document_links | |||
There was a problem hiding this comment.
we could extract this to Decorators::FromDocuments to share common Document - related presentation logic.
kowal
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some problems with using both
arbreanderbtemplates like something is not rendering or rendering twice. Maybe we should stick with erb in most cases, just need to find a better alternative for styling columns, for now I usedArbre::Contextand column component.