Feature/documents export #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowal
force-pushed
the
feature/documents-export
branch
from
0943375
to
7eb3c53
Compare
kowal
force-pushed
the
feature/documents-export
branch
from
e00c881
to
beeab54
Compare
kowal
commented
Aug 29, 2019
|
|
||
| if documentable_klass.present? && documentable_params.present? | ||
| results = results.where( | ||
| documentable: documentable_klass.ransack(documentable_params).result |
There was a problem hiding this comment.
@tsubik thanks for improving this! works like a charm now)
Currently selected Legislations filters must be preserved when generating CSV for Documents.
kowal
force-pushed
the
feature/documents-export
branch
from
beeab54
to
5c7e268
Compare
tsubik
reviewed
Aug 30, 2019
app/admin/documents.rb
Outdated
| column :external_url | ||
| column :language | ||
| column :last_verified_on | ||
| column 'Law ID', &:document_legacy_law_id |
There was a problem hiding this comment.
I'm not sure if we need that legacy law ID for our import/export.
There was a problem hiding this comment.
This is the only way to match documents with legislations. This could be handy during: export -> manual change -> import scenario. Also, it doesn't break anything.
I do agree that in the future, after the initial import, this probably will be removed.
There was a problem hiding this comment.
That's documentable_id for.
There was a problem hiding this comment.
ok, I removed this for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
documents.csvon the legislations and litigations index pages.Id, Name, External URL, language, Last verified on, Law ID, Documentable ID, Documentable Type