Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature): TPI (sectors, companies) controllers, chart API & views #57

Merged
merged 56 commits into from Sep 30, 2019
Merged

(feature): TPI (sectors, companies) controllers, chart API & views #57

merged 56 commits into from Sep 30, 2019

Conversation

kowal
Copy link
Contributor

@kowal kowal commented Sep 13, 2019 •
edited

Summary

Used https://chartkick.com/#highcharts with highcharts.

Pages

Sectors index

  • Management Quality: All sectors (pie chart)
    • Market Cap (bubble chart) 🤕 not in this PR
  • Carbon Performance: All sectors (stacked chart)

Sector Details page

  • Management Quality: Sector (pie chart)
    • Levels (NOT chart, just flexbox)
  • Carbon Performance: Sector (line chart)

Company Details page

  • Management Quality: Company (gauge?) not in this PR
  • Management Quality: Company (line chart) not in this PR
  • Company question/answers list
  • Carbon Performance: Company (line chart)
  • Company Info

TODO:

  • fix issues with assessment date
  • use real data for Carbon Performance: All sectors chart (@agwozdowski)
  • add controllers or integration specs

Go to http://localhost:3000/tpi/sectors
Zrzut ekranu 2019-09-14 o 08 33 14

@kowal kowal changed the title [TPI frontend] Sectors dashboard PoC [WIP] (feature): TPI frontend PoC Sep 13, 2019
@kowal kowal force-pushed the feature/tpi-controllers branch 3 times, most recently from d8df9f5 to 975c76b Compare September 17, 2019 14:49
@kowal kowal force-pushed the feature/tpi-controllers branch 2 times, most recently from ffb5eb5 to 5f93d1f Compare September 19, 2019 10:34
@kowal kowal changed the title [WIP] (feature): TPI frontend PoC [WIP] (feature): TPI (sectors, companies) controllers, chart API & views Sep 20, 2019
@kowal kowal changed the title [WIP] (feature): TPI (sectors, companies) controllers, chart API & views (feature): TPI (sectors, companies) controllers, chart API & views Sep 20, 2019
@kowal kowal marked this pull request as ready for review September 20, 2019 07:16
agwozdowski
agwozdowski reviewed Sep 22, 2019
View reviewed changes
Copy link
Contributor

@agwozdowski agwozdowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lack of unit tests ;)

app/helpers/chart_helper.rb Show resolved Hide resolved
app/services/api/charts/company.rb Outdated Show resolved Hide resolved
app/services/api/charts/company.rb Outdated Show resolved Hide resolved
simaob
simaob reviewed Sep 23, 2019
View reviewed changes
Copy link
Contributor

@simaob simaob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great start and nice PR! =)

The code structure seems good to me, and is a great step forward in this frontend. I left a couple of small comments, but nothing too big. Thanks!

app/controllers/sectors_controller.rb Outdated Show resolved Hide resolved
app/services/api/charts/company.rb Outdated Show resolved Hide resolved
app/services/api/charts/company.rb Outdated Show resolved Hide resolved
config/routes.rb Outdated Show resolved Hide resolved
tsubik
tsubik requested changes Sep 23, 2019
View reviewed changes
Copy link
Collaborator

@tsubik tsubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

Couple comments about chart data and making sure to take the last assessment.

app/assets/stylesheets/tpi.scss Show resolved Hide resolved
app/services/api/charts/company.rb Outdated Show resolved Hide resolved
app/services/api/charts/company.rb Show resolved Hide resolved
app/services/api/charts/sector.rb Outdated Show resolved Hide resolved
config/routes.rb Show resolved Hide resolved
app/services/api/charts/sector.rb Outdated Show resolved Hide resolved
app/services/api/charts/sector.rb Outdated Show resolved Hide resolved
kowal and others added 23 commits September 27, 2019 15:21
@kowal
companies_scope in sectors contoller can be private
52f1652
@kowal
extract questions_by_level to MQ::Assessment model
59c6117
@kowal
extrac Api::Presenters::Company
2c40777
@kowal
move everything under :tpi namespace
a037323
@kowal
company cp|mq assessments are ordered with latest first (by assessmen…
b3915ce 
…t date)
@kowal
calculate sector avg emissions for company latest CP assessments (not…
fc53e70 
… all of them)
@kowal
remove ordering from scope
a6e1c04
@agwozdowski @kowal
First version of "Carbon Performance: All sectors" chart with real data
4e3eb5a
@agwozdowski @kowal
Fix rubocop error
5436087
@agwozdowski @kowal
Fix case when company does not have any emission reported
96adf8c
@agwozdowski @kowal
Move cp_benchmark chart to another file
473f8b6
@agwozdowski @kowal
Unit tests for Carbon Performance: All sectors chart
207554e
@agwozdowski @kowal
Documentation for Carbon Performance: All sectors
28b7fb6
@agwozdowski @kowal
Refactoring for Carbon Performance: All sectors
28c043e
@agwozdowski @kowal
Unit tests for company.rb charts
f3e2ddd
@agwozdowski @kowal
Unit tests for sector.rb charts
518aced
@agwozdowski @kowal
One more corner case with more unit tests
69937c7
@agwozdowski @kowal
Fix Rubocop error
2bbddf8
@agwozdowski @kowal
Get CP Benchmarks from last release
1b2722e
@agwozdowski @kowal
Fix tests after rebase
8db1d0a
@agwozdowski @kowal
Fix rubocop
e5b466e
@agwozdowski @kowal
Eager loading and refactoring
e263e6f
@kowal
update mq_assessment.questions usage
80eb81f
@kowal
(chart-api) fix for fetching sector benchmarks + clean up (#75)
08e932b 
* extract Sector#latest_released_benchmarks and Company#latest_sector_* helpers

* improve docs

* fast return

* udpate comment
@kowal kowal merged commit 8d3094f into develop Sep 30, 2019
@kowal kowal deleted the feature/tpi-controllers branch September 30, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simaob simaob simaob left review comments

@tsubik tsubik tsubik requested changes

@agwozdowski agwozdowski agwozdowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kowal @simaob @tsubik @agwozdowski